Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented optional asynchronous authentication #1002

Merged
merged 1 commit into from May 4, 2018

Conversation

schantaraud
Copy link

Changes:

  • The server.authentication function can either return a value or call an optional callback to allow for authentication from databases or other webservices. If both are used, the first one wins, the second is ignored.
  • In case of authentication error, a SOAP Fault is returned with a status code of 401 (previously: standard exception with optional stacktrace, which soapClient doesn't like).

All existing tests results unchanged, new tests: test/server-authentication-test.js.

All feedback is welcome.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 93.714% when pulling 92ec3c4 on schantaraud:master into 7a5550a on vpulim:master.

1 similar comment
@coveralls
Copy link

coveralls commented Mar 1, 2018

Coverage Status

Coverage increased (+0.1%) to 93.714% when pulling 92ec3c4 on schantaraud:master into 7a5550a on vpulim:master.

@jsdevel
Copy link
Collaborator

jsdevel commented May 4, 2018

@schantaraud the node 4 tests are failing. can you take a look?

@jsdevel jsdevel merged commit 9ea32e2 into vpulim:master May 4, 2018
@jsdevel
Copy link
Collaborator

jsdevel commented May 4, 2018

nvm. node 4 is dead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants