Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to for an envelopeKey for WSSecurity #1143

Merged
merged 2 commits into from May 14, 2021

Conversation

timemachine3030
Copy link
Contributor

@timemachine3030 timemachine3030 commented May 4, 2021

  • When including an envelopeKey in client creation the mustUnderstand and actor attributes
    will not have the correct prefix.
  • Passing this value to as an option to creating the security instance is not an ideal solution
  • This change does not fix the same issue that exists in WSSecurityCert

 - When including an `envelopeKey` in client creation the `mustUnderstard` and `actor` attributes
  will not have the correct prefix.
 - Passing this value to as an option to creating the security instance
  is not an ideal solution
 - This change does not fix the same issue that exists in WSSecurityCert
@coveralls
Copy link

coveralls commented May 4, 2021

Coverage Status

Coverage increased (+0.05%) to 95.068% when pulling befe127 on timemachine3030:WSSecurity-envelopeKey into bf3b07d on vpulim:master.

@jsdevel jsdevel merged commit 25954fd into vpulim:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants