* prefer SOAPAction header over the body name to get the actual method name #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lah8789
pushed a commit
to lah8789/node-soap
that referenced
this pull request
Jul 27, 2021
|
There is a bug in this PR. Line 289. If SOAPAction header is not set, this causes 500 Server internal error, because soapAction variable is undefined. |
|
please submit a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had many cases when I had to modify my wsdl to let node-soap to find and trigger the right method. But in some cases I have no options to modify wsdl file. The problem is that node-soap looks for method name using body name. This works in majority of cases but not in all.
At the same time most of software send the SOAPAction header (and node-soap client as well). This header better defines the method to call. My change switches node-soap to first search the method by SOAPAction header and if it is not available then search by the body name.