Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* check method style if exists instead of binding style #1153

Merged
merged 5 commits into from Aug 23, 2021
Merged

* check method style if exists instead of binding style #1153

merged 5 commits into from Aug 23, 2021

Conversation

paulish
Copy link
Contributor

@paulish paulish commented Jul 27, 2021

Current implementation gets the method style from then binding definition while method can have different style than binding.

The new implementation gets the style first from the method and then from the binding if method has no style.

To fix the problem. I made several changes:

  1. binding.topElements are created for any binding style but populated with elements of only 'document' style
  2. moved methodName detection by soapAction from _executeMethod to _process and removed soapAction property from IExecuteMethodOptions which I added in previous patch.
  3. added code to get style from the called method

I also added a test with an example.

@jsdevel jsdevel merged commit b94b0a7 into vpulim:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants