Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publicly expose wsdl in Client #1167

Merged
merged 1 commit into from Nov 3, 2021
Merged

Publicly expose wsdl in Client #1167

merged 1 commit into from Nov 3, 2021

Conversation

imgx64
Copy link
Contributor

@imgx64 imgx64 commented Sep 27, 2021

The wsdl property in Client is currently private. And while it's possible to manually construct it using new WSDL(...), the actual implementation as done in createClient(...) is more complicated and does caching/fetching from file or url/etc.

@jsdevel
Copy link
Collaborator

jsdevel commented Oct 1, 2021

why do you need this @imgx64 ?

@imgx64
Copy link
Contributor Author

imgx64 commented Oct 1, 2021

I need to manually call wsdl.objectToXML to convert the request to XML without actually sending it.

@onury
Copy link
Contributor

onury commented Oct 2, 2021

We also have cases where we extend classes and need access to wsdl.

@jsdevel jsdevel merged commit f6a0979 into vpulim:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants