Continuation PR #1169: change content-type-parser to whatwg-mimetype #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s of the old request module to Axios, improve documentation of several functions' arguments.
The upstream pull request 1169 failed linting with the following error: ERROR: /home/runner/work/node-soap/node-soap/src/http.ts:9:1 - Import sources within a group must be alphabetized.
|
@tommyhtran please check the build log and ensure it passes |
…d to MIMEType.parse(). The MIMEType constructor method throws an Error object on failure, unlike the call to contentTypeParser() from the 'content-type-parser' package, which returned null on failure. To maintain backwards compatibility, use MIMEType.parse(), which returns null on failure.
…rom the parsed HTTP Content-Type header.
|
Please accept #1178 before accepting this pull request because whatwg-mimetype v3.0.0 specifies Node |
|
@jsdevel Is there anything holding up these PRs? |
|
@tommyhtran i merged #1178. please update this branch accordingly. |
This was referenced Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm picking up where @lagden left off from #1169.