Fix build in Node.js 18 by re-encrypting test key #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The encrypted private key test/certs/agent2-key-with-password.pem was encrypted with DES, which is unsupported in Node.js 18. I re-encrypted it with AES, and now the build works in Node.js 18.
|
@jsdevel I don't know why the build fails in CI. It works fine locally. I think it's related to IPv6? |
|
I tried to fix the CI build by explicitly listening on |
|
@e6c31d still failing |
e6c31d
force-pushed
the
fix_encrypted_key_node18
branch
from
7c69412
to
b93ea37
Compare
|
@jsdevel Can you re-run the build? I believe the build issue is fixed. |
|
@jsdevel Sorry to ping you repeatedly, but can you please re-run the build and merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The encrypted private key test/certs/agent2-key-with-password.pem was encrypted with DES, which is unsupported in Node.js 18. I re-encrypted it with AES, and now the build works in Node.js 18.