Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update axios version #1229

Merged
merged 1 commit into from
Apr 5, 2024
Merged

update axios version #1229

merged 1 commit into from
Apr 5, 2024

Conversation

rrez2002
Copy link
Contributor

No description provided.

Copy link

@juan-turk-simplisafe juan-turk-simplisafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please eliminate the spaces (indentation) so it is easier to see what the changes are?

@@ -19,7 +19,7 @@
"xml-crypto": "^3.0.0"
},
"peerDependencies": {
"axios": "^0.27.2"
"axios": ">=1.5.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not sure why this is a peer dependency. This module CAN NOT function without axios, it clearly is a dependency, lol

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That point is no longer valid. this package can easily state that it directly depends on axios >= 1.5.0

In my project I would be able to use any axios version that satisfies the constraint

Copy link

@juan-turk-simplisafe juan-turk-simplisafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any news about this? can we merge this

@boukmi
Copy link

boukmi commented Dec 28, 2023

Any update? can this be merged?
Thank you

@Dragonox77
Copy link

Bump

@boxexchanger
Copy link

@jsdevel +1

@swiesmann
Copy link

swiesmann commented Jan 10, 2024

We would also appreciate the PR merge 👍 as there is a known vulnerability for the axios version that is in use.

See GitHub's advisory: GHSA-wf5p-g6vw-rhxx

@Caryyon
Copy link

Caryyon commented Jan 10, 2024

This dependency vulnerability is a show stopper for our app, without being able to update axios our app won't pass it's pipeline vulnerability scans.

@invariants
Copy link

This PR with essentialy the same goal is open for almost one year: #1212 (has also been kept up to date). I think this project is dead and needs to be forked.

@juan-turk-simplisafe
Copy link

Is there already a fork of this repo that is updated?
This repo has a vulnerable version of Axios and I need to update it in my project as soon as possible.

@lalitsharma309
Copy link

Any update? can this be merged?
Thank you

@boxexchanger
Copy link

Why did the developers decide to stop at 999 commits? Because they got tired of counting and thought it would be more impressive to start the next thousand with a fresh cup of coffee! 😃

@jackhollowaypls
Copy link

Please can this get approved. It's the only package left in my project that has a dependancy on this old version of axios, all other packages have updated

@Dragonox77
Copy link

Can you release it ?

@mfuqua3
Copy link

mfuqua3 commented Feb 8, 2024

Bump. Can this please get merged and released.

@Deprasos
Copy link

Same here still waiting for this to be merged and released 👍

@SiRocke
Copy link

SiRocke commented Mar 6, 2024

Bump!

@alexHerrmio
Copy link

Please merge it ❤️

@juan-turk-simplisafe
Copy link

Bump!

@dkbhadeshiya
Copy link

This really needs to be merged since older axios versions are having vulnerabilities.

@ronnie-gee
Copy link

Bump!

@Dragonox77
Copy link

Guys, it is probably better to use another lib, since the author do not seems to be active and probably do not care.

If a vulnerability is discovered tomorrow, we can't wait for the author to merge the fix in 3 months. This lib should be marked as deprecated or inactive. Maybe we should ask NPM to pressure them if they want to keep their package active.

@hamidouikene
Copy link

@Dragonox77, could you suggest any other lib that we can use here?

@Dragonox77
Copy link

@hamidouikene

@Dragonox77, could you suggest any other lib that we can use here?

https://www.npmjs.com/package/strong-soap (updated 7 days ago)
https://www.npmjs.com/package/easy-soap-request (updated 1 month ago)

@juan-turk-simplisafe
Copy link

I agree with @Dragonox77, we are moving to another library.

@vpulim vpulim merged commit 999126a into vpulim:master Apr 5, 2024
@swiesmann
Copy link

Thank you for merging, @vpulim ! 👍 Looking forward to the release.

@JackHammer29
Copy link

@vpulim Any update on the release please?

@w666
Copy link
Collaborator

w666 commented Apr 16, 2024

Hi All, I will be helping to maintain this project for some time, discussing details with @vpulim atm. Hopefully I will release this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet