Fixing issue #613: Add capability to throw Fault from async function

[ghughal]

No description provided.

[brodin]

What is the status of this? Seams like @ghughal have made a great effort to make these server handlers useful. Async errors are very common in node.js and needs to be supported. Looked over the commits and it seams like a no-brainer - even thou the callback convention is broken by having cb(data, err) rather than cb(err, data). Solveing https://github.com/vpulim/node-soap/issues/613

[brodin]

I did my own take on this and found out why the tests failed #641

[ghughal]

@brodin - I too am waiting for someone to merge it. It would be great if someone can look at it and merge it or provide feedback.

[simonjosefsson]

I'm not a maintainer but you need to do the following first

• Read and follow CONTRIBUTING (squashing the commits is a must)
• Have the tests pass (run npm test locally and see the logs on Travis)

[herom]

Hello @ghughal - thanks a lot for you contribution and sorry for the extremely long delay 😞

As @simonjosefsson said, please take a look at our Guideline on Submitting a Pull Request as there are some points which must be necessarily fulfilled in order to get your PR merged.

The main points are (as already mentioned by @simonjosefsson :

• Rebase/Squash your commits into a single one (more information about this is available in the guideline)
• run npm test locally and take a look at the logs at Travis CI

thanks 👍

[jsdevel]

Closing for lack of activity.

[spawnrider]

Even you can't throw a Fault from an async function, you can use the callback method in order to return it like this :

    db.any("select * from users where active=$1", [true])
      .then(function (data) {
        cb({});
      })
      .catch(function (error) {
        cb({
          Fault: {
            faultcode: faultCode,
            faultstring: faultString,
            detail: {
              "ns:FaultInformation": {
                "ns:FaultCode": detailedFaultCode,
                "ns:FaultText": detailedFaultText
              }
            },
            statusCode: 500
          }
        });
      });
  }