Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom NS on a request #633

Closed
wants to merge 1 commit into from
Closed

custom NS on a request #633

wants to merge 1 commit into from

Conversation

d65yan
Copy link

@d65yan d65yan commented Apr 16, 2015

The idea behind this simple modification is to optionally let the developer define custom NS for the message of the request through the name of the request object properties. it also uses a name attribute in so the method can be renamed t will

…rs to define their own namespace in the message. this is sometimes required when the swdl file is not in sync with the service expected parameters. skipNS will remove the namespaces from thre message so the method name needs to be provided through the name property
@herom
Copy link
Contributor

herom commented May 19, 2015

Hello @d65yan - thanks a lot for your contribution 👍

In order to get your PR merged I'll have to ask you to follow our Guideline on Submitting a Pull Request and work through the open points, which are:

  • Run npm test locally and take a look at the Travis CI logs in order to make the PR pass all the tests

Thanks a lot for your patience 👍

@jsdevel
Copy link
Collaborator

jsdevel commented Sep 16, 2015

Closing for lack of activity.

@jsdevel jsdevel closed this Sep 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants