Fixed issue when an error was undefined: undefined #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This occurs on responses that from what I can tell do not have an xsi:type of string, Thus these objects would not have an internal $value and would return undefined. This commit keeps backwards compatibility and falls back to assuming the error was a string.
|
Looks good to merge 👍 - thanks a lot 😄 |
herom
added a commit
that referenced
this pull request
Nov 2, 2015
Fixed issue when an error was undefined: undefined
Closed
|
Do you plan to release a new version on npm with the fix soon? Thanks! |
|
👍 |
1 similar comment
|
👍 |
|
done @jguepin sorry for the delay. |
diarmaidm
pushed a commit
to diarmaidm/node-soap
that referenced
this pull request
Feb 3, 2016
Fixed issue when an error was undefined: undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This occurs on responses that from what I can tell do not have an
xsi:type of string, Thus these objects would not have an internal $value
and would return undefined.
This commit keeps backwards compatibility and falls back to assuming the
error was a string.