Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error handling for missing SOAP elements #869

Merged
merged 1 commit into from Aug 12, 2016
Merged

better error handling for missing SOAP elements #869

merged 1 commit into from Aug 12, 2016

Conversation

prasunsultania
Copy link
Contributor

Better error handling to speed up debugging:

  1. SOAP message missing envelope and body
  2. request/response tests incorrect SOAP method name

@coveralls
Copy link

coveralls commented Aug 11, 2016

Coverage Status

Coverage increased (+0.008%) to 92.536% when pulling 0797eaf on prasunsultania:master into afc2222 on vpulim:master.

assert.equal(body.indexOf('Failed to parse the SOAP Message body') !== -1, true);
done();
});

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no empty line between blocks

@coveralls
Copy link

coveralls commented Aug 11, 2016

Coverage Status

Coverage increased (+0.008%) to 92.536% when pulling 77d5c4d on prasunsultania:master into afc2222 on vpulim:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 92.536% when pulling 9b4478f on prasunsultania:master into afc2222 on vpulim:master.

1 similar comment
@coveralls
Copy link

coveralls commented Aug 11, 2016

Coverage Status

Coverage increased (+0.008%) to 92.536% when pulling 9b4478f on prasunsultania:master into afc2222 on vpulim:master.

@prasunsultania
Copy link
Contributor Author

@jsdevel have removed the empty line and squashed the commits into one.

@jsdevel
Copy link
Collaborator

jsdevel commented Aug 11, 2016

Thanks @prasunsultania ! See my other comments.

@coveralls
Copy link

coveralls commented Aug 12, 2016

Coverage Status

Coverage increased (+0.008%) to 92.536% when pulling 4761f03 on prasunsultania:master into afc2222 on vpulim:master.

@prasunsultania
Copy link
Contributor Author

prasunsultania commented Aug 12, 2016

@jsdevel have made changes by removing all empty lines as suggested. PLMK if it looks good.

Strange that npm run coveralls failed during the build with some error related to coverall itself Bad response: 422 {"message":"Couldn't find a repository matching this job.","error":true}

Is their a way to re-run the build check, as the build failed only for node.js 4 and does't seems to be an error with code or test cases ?

@jsdevel
Copy link
Collaborator

jsdevel commented Aug 12, 2016

tests are failing. Can you fix them?

@prasunsultania
Copy link
Contributor Author

@jsdevel Please see the logs , tests are passing. It is the coveralls which is failing. Is there a way to re-run travis build ?

@jsdevel
Copy link
Collaborator

jsdevel commented Aug 12, 2016

Ahh, I see. I kicked off the failed job again. Hopefully it passes.

@prasunsultania
Copy link
Contributor Author

@jsdevel it did pass :)

@jsdevel
Copy link
Collaborator

jsdevel commented Aug 12, 2016

\o/

@jsdevel jsdevel merged commit 59aa639 into vpulim:master Aug 12, 2016
@jsdevel
Copy link
Collaborator

jsdevel commented Aug 12, 2016

Thanks a ton @prasunsultania !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants