readme.md clarifications, examples and typos #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks a lot @mwkarttu - this makes it more read- & understandable indeed 👍 |
|
Could you please rebase your branch in order to make the tests pass? this would be awesome 😸 |
Tried to keep it concise, I found it a little incoherent before.
extended a few examples for clarity
|
Rebased and added a few more things. |
sycnus
changed the title
|
thanks a ton @mwkarttu 👍 |
jcald1
pushed a commit
to jcald1/node-soap
that referenced
this pull request
Jun 8, 2017
* clarified WSSecurity example in readme.md Tried to keep it concise, I found it a little incoherent before. * typos and "linting" * reorganized wsdlOptions slightly extended a few examples for clarity * added debugging proxy example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to keep it concise, I found it a little incoherent before.