JupyterLab 1.x support #26
Conversation
|
Thank you Kyle for this. I will try build it on my computer this weekend and test out your changes.
Thanks
John
From: "Kyle Dunn" <notifications@github.com>
To: "vpython/vpython-jupyter" <vpython-jupyter@noreply.github.com>
Cc: "Subscribed" <subscribed@noreply.github.com>
Sent: Friday, September 13, 2019 3:08:18 PM
Subject: [vpython/vpython-jupyter] JupyterLab 1.x support (#26)
Great project you all have here.
I noticed #17 as well when I went to play around with this again and figured I'd take a shot at fixing it. These changes seem to work for me after following the steps in the labextension/vpython/README.md , I'm definitely not up to speed on the contribution guidelines for this project but please let me know if there are other things I need to do as part of this PR.
Cheers,
Kyle
You can view, comment on, or merge this pull request online at:
#26 Commit Summary
* JupyterLab 1.x support
File Changes
* M labextension/vpython/README.md (2)
* M labextension/vpython/package-lock.json (1191)
* M labextension/vpython/package.json (16)
* M labextension/vpython/src/glowcommlab.js (6)
* M labextension/vpython/src/index.ts (8)
* M labextension/vpython/tsconfig.json (4)
* D labextension/vpython/yarn.lock (706)
Patch Links:
* https://github.com/vpython/vpython-jupyter/pull/26.patch
* https://github.com/vpython/vpython-jupyter/pull/26.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub , or mute the thread .
|
There was a problem hiding this comment.
@kdunn926 -- thanks for opening this PR! Most of the demo notebooks I tried worked without a problem (and the one that didn't likely has nothing to do with your changes).
Could you please add your name to https://github.com/vpython/vpython-jupyter/blob/master/CONTRIBUTORS.md?
@jcoady and @BruceSherwood -- I'm ok with merging this if you are.
labextension/vpython/README.md
Outdated
| @@ -22,6 +22,7 @@ For a development install (requires npm version 4 or later), do the following in | |||
| npm install | |||
| npm install --save @jupyterlab/notebook @jupyterlab/application @jupyterlab/apputils @jupyterlab/docregistry @phosphor/disposable script-loader | |||
There was a problem hiding this comment.
| npm install --save @jupyterlab/notebook @jupyterlab/application @jupyterlab/apputils @jupyterlab/docregistry @phosphor/disposable script-loader |
I was able to omit this and still build the extension successfully.
There was a problem hiding this comment.
Incorporated this change in squash-commit f363918.
labextension/vpython/README.md
Outdated
| @@ -22,6 +22,7 @@ For a development install (requires npm version 4 or later), do the following in | |||
| npm install | |||
| npm install --save @jupyterlab/notebook @jupyterlab/application @jupyterlab/apputils @jupyterlab/docregistry @phosphor/disposable script-loader | |||
| npm run build | |||
There was a problem hiding this comment.
| npm run build |
I think this can be left out too (npm run build seems to happen as part of npm install)
There was a problem hiding this comment.
Incorporated this change in squash-commit f363918.
labextension/vpython/package.json
Outdated
| "script-loader": "^0.7.2", | ||
| "typescript": "~2.9.2" | ||
| "typescript": "^3.6.3", | ||
| "file-loader": "^4.2.0" |
There was a problem hiding this comment.
| "file-loader": "^4.2.0" | |
| "file-loader": "^4.2.0", | |
| "webpack": "^4.0.0" |
Adding webpack eliminated this warning: "npm WARN file-loader@4.2.0 requires a peer of webpack@^4.0.0 but none is installed. You must install peer dependencies yourself."
There was a problem hiding this comment.
Fine with me, Matt, but this is way outside my field of competence.
There was a problem hiding this comment.
Hi Matt , I am OK with you merging this fix.
There was a problem hiding this comment.
Incorporated this change in squash-commit f363918.
* Added some workarounds to ensure fonts are included in the webpack packing * Simplify README steps * Update contributors list
kdunn926
force-pushed
the
fix_jupyterlab_1x_support
branch
from
7c5a9e6
to
f363918
Compare
|
closing/reopening to try to trigger travis build... |
|
Thanks, @kdunn926, we'll try to get the release out this week! |
Great project you all have here.
I noticed #17 as well when I went to play around with this again and figured I'd take a shot at fixing it. These changes seem to work for me after following the steps in the
labextension/vpython/README.md, I'm definitely not up to speed on the contribution guidelines for this project but please let me know if there are other things I need to do as part of this PR.Cheers,
Kyle