Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining shadow issues #380

Open
spiralhalo opened this issue May 25, 2022 · 1 comment
Open

Remaining shadow issues #380

spiralhalo opened this issue May 25, 2022 · 1 comment

Comments

@spiralhalo
Copy link
Collaborator

  • Entities don't cast shadow is they are in camera occlusion-culled region.
  • Esp. underground: shadow holes caused by the objects that casts shadow being outside the light frustum's near clipping plane.
  • Esp. underground, during sunrise and sunset: shadow holes caused by back-face culling.
  • Extra: being able to limit shadow render distance reliably can help alleviate the cost of rendering more shadows to solve above issues.
@spiralhalo
Copy link
Collaborator Author

Entities don't cast shadow if they are in camera occlusion-culled region.

Correction: Entities don't cast shadow if they are outside of camera frustum most likely. Terrain iterator seem to already have a routine to set shadow-visible region to "entities visible", so likely not occlusion issue.

Potential solution is to perform a second "should render" check using a shadow-aware frustum during entity rendering, and if passing despite failing the first check, render the entity as shadow extras only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant