MSSQL: avoid warnings if result is invalid

[Gargaj]

No description provided.

[vrana]

What problem is this trying to solve? Ignoring errors usually lead to more problems. It should at least return false in case of an error.

[Gargaj]

@vrana It's not about ignoring errors; Adminer throws unnecessary PHP warnings when the SQL query fails because the query result is false: http://pbrd.co/1ud3Si2

[vrana]

If there's a problem then it should return false.

[Gargaj]

@vrana It doesn't in the original either: https://github.com/vrana/adminer/blob/master/adminer/drivers/mssql.inc.php#L65 - is that a bug there too?

[vrana]

Yes. The original code at least triggers a warning which reports the error in some way. This code mutes it completely.

[Gargaj]

@vrana It doesn't mute it at all, look at the screenshot above: http://pasteboard.co/ooveElb.png - the "Error in query" line still will be visible, just without the unnecessary PHP warnings around it.

[Gargaj]

Either way, I modified the pull to return false.

[vrana]

Merged, thanks.