Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ElasticSearch integration #231

Closed
wants to merge 27 commits into from
Closed

Enhance ElasticSearch integration #231

wants to merge 27 commits into from

Conversation

fabiomontefuscolo
Copy link
Contributor

Hello!

I'm using Adminer to take care of my data indexed on ElasticSearch. There are some methods sometimes I need, like delete, edit and insert records, but is actually missing.

This pull request is a proposal for those missing methods and a small bug fix to show counts for each type. Could you check it?

Thank you in advance!
Cheers

@fabiomontefuscolo
Copy link
Contributor Author

There are some problems with your travis environment. My changes was accepted for php 7.1 but is broken for 5.3. The message is:

0.02s$ phpenv global 5.3
rbenv: version `5.3' not installed
The command "phpenv global 5.3" failed and exited with 1 during .
Your build has been stopped.

@marclaporte
Copy link

For the record, this is how we use it: Adminer is shipped as part of the Elasticsearch app for ClearOS:
http://wikisuite.org/How-to-install-Elasticsearch-on-ClearOS

Thank you Adminer!


$search = $connection->query("_search", array(
"size" => 0,
>>>>>>> elastic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've committed a merge conflict.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! I think I messed .travis.yml also, so I reverted it, but adding two commands on script section to check also the compiled file. Because on first of my commits, the code passed on linter, but compiler could not generate a good compiled file.

@vrana
Copy link
Owner

vrana commented Jan 19, 2018

Thanks for your work. I don't use ElasticSearch so I've merged this without testing. I've fixed the style to be same as in the rest of Adminer. Please create a separate PR for the Travis change. It seems to me that the result of test $? -eq 1 would be ignored but I'm not an expert in Travis.

@vrana vrana closed this Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants