Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails with macOS 10.12 #21

Closed
MarcoNiemann opened this issue Oct 29, 2017 · 3 comments
Closed

Build fails with macOS 10.12 #21

MarcoNiemann opened this issue Oct 29, 2017 · 3 comments

Comments

@MarcoNiemann
Copy link

With Python 2.7.14 the compilation fails on macOS 10.12. Requirements (cython, cysignals, future and numpy) are satisfied. Compilation fails both using pip and manual conversion.

C-Compiler is:

Apple LLVM version 9.0.0 (clang-900.0.38)
Target: x86_64-apple-darwin16.7.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
src/fasttext_access.cpp:54:48: error: 'find' is a private member of 'fasttext::Dictionary'
ALLOW_CONST_METHOD_ACCESS(Dictionary, int32_t, find, const std::string&);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
@vrasneur
Copy link
Owner

Hi @MarcoNiemann,

The only supported C++ compiler is g++.
(pyfasttext uses complicated template hacks to access fastText private members and members, which are only supported by g++).

@vrasneur
Copy link
Owner

I've added support for clang (it should support clang >= 3.6.0).

Can you update the source code and try again ?

@MarcoNiemann
Copy link
Author

Many thanks @vrasneur. Works like a charm now. 👍 And cool that you added the clang support. Wasn't aware that it would only work with g++.

The issue can thus be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants