Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gui): last modified is not localized #723

Merged
merged 3 commits into from
Apr 6, 2024

Conversation

anatawa12
Copy link
Member

@anatawa12 anatawa12 added the localization Improvements or additions to localization label Apr 6, 2024
@anatawa12 anatawa12 marked this pull request as ready for review April 6, 2024 07:01
@Sayamame-beans
Copy link
Collaborator

Unity Hubは日本語の場合は数字と文字の間に空白無いようです
あるのとないのとどっちが良いのか比較して考えたいので少々お待ち下さい

@Sayamame-beans
Copy link
Collaborator

Sayamame-beans commented Apr 6, 2024

うーん…

比較
空白ありでも悪くはないけれど、無しで良い…かな…?

@@ -13,6 +13,19 @@
"type": "Type",
"unity": "Unity",
"last modified": "Last modified",
"moments ago": "Moments ago",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Just now"(Misskeyと同じ)でも可かもしれない

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一応一分くらいがそうなのでmoments agoにした。nowとはちょっと違う気がしたので

@@ -13,6 +13,13 @@
"type": "種類",
"unity": "Unity",
"last modified": "最終更新日",
"moments ago": "たった今",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misskeyから持ってきました
なんとなくこっちの方が良さそうだった

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一分前がたった今かは少し微妙な気もしなくもないけど悪くもないのでヨシ

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

空白無くしました

@anatawa12 anatawa12 merged commit d451f0f into master Apr 6, 2024
17 checks passed
@anatawa12 anatawa12 deleted the fix-i18n-for-last-modified branch April 6, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Improvements or additions to localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants