Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned layout for Backup section in Settings page #731

Merged
merged 4 commits into from
Apr 6, 2024
Merged

Cleaned layout for Backup section in Settings page #731

merged 4 commits into from
Apr 6, 2024

Conversation

Spokeek
Copy link
Contributor

@Spokeek Spokeek commented Apr 6, 2024

Fixes #716

@anatawa12
Copy link
Member

image

anatawa12
anatawa12 requested changes Apr 6, 2024
View reviewed changes
Copy link
Member

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new

vrc-get-gui/app/settings/page.tsx Show resolved Hide resolved
Sayamame-beans
Sayamame-beans approved these changes Apr 6, 2024
View reviewed changes
Copy link
Collaborator

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has resolved the problem to some extent. Looks good!

(off-topic: I noticed that the area behind the : has no space, but this is not caused by this PR, but was there originally. (out of the area of this PR))

anatawa12
anatawa12 approved these changes Apr 6, 2024
View reviewed changes
Copy link
Member

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@anatawa12 anatawa12 merged commit 787466d into vrc-get:master Apr 6, 2024
16 checks passed
@Spokeek Spokeek deleted the fix-716 branch April 6, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anatawa12 anatawa12 anatawa12 approved these changes

@Sayamame-beans Sayamame-beans Sayamame-beans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Spokeek @anatawa12 @Sayamame-beans