Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gui): check for updates button on the settings page #762

Merged
merged 2 commits into from
Apr 10, 2024
Merged

feat(gui): check for updates button on the settings page #762

merged 2 commits into from
Apr 10, 2024

Conversation

anatawa12
Copy link
Member

Fixes #733

@anatawa12 anatawa12 marked this pull request as ready for review April 10, 2024 14:46
Sayamame-beans
Sayamame-beans approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ぱっと見た感じは良さそうです
動作/表示未確認

@anatawa12 anatawa12 merged commit cca5eab into master Apr 10, 2024
18 checks passed
@anatawa12 anatawa12 deleted the check-for-updates-on-settings branch April 10, 2024 15:02
@Sayamame-beans
Copy link
Collaborator

良くなかった
更新がなく最新であったことを示すトーストかダイアログがあった方が良さそうです

@anatawa12
Copy link
Member Author

更新がなく最新であったことを示すトーストかダイアログがあった方が良さそうです

知る限りできないからこの実装になってる

@Sayamame-beans
Copy link
Collaborator

なるほど…

@anatawa12 anatawa12 mentioned this pull request May 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sayamame-beans Sayamame-beans Sayamame-beans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

設定ページからバージョンアップ可能にしてほしい
2 participants
@anatawa12 @Sayamame-beans