fix clientsim spawn bug #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation related spawning errors this is needed because we call into the same spawn function when initially loading in the localplayer, so sequential spawning offsets get messed up
momo-the-monster
approved these changes
May 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a function to reset spawn order when initializing clientsim, which prevents preinitialization related spawning errors.
This is needed because we call into the same spawn function when initially loading in the localplayer, so sequential spawning offsets get messed up. (We load in the player at onBeforeSceneLoad, then clientsim respawns them at Start after everything is instantiated into the scene, so the sequential spawn counter gets ticked twice at startup)
There could be a better solution where we only call the spawn function once, but that's digging into levels of initialization-order-type spaghetti that I don't think make sense to tackle here.