Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Audio Link will be added to projects without Audio Link during unity 2022 migration #434

Closed
anatawa12 opened this issue Feb 26, 2024 · 3 comments
Labels
bug Something isn't working vpm-core Issues related to the vpm-core

Comments

@anatawa12
Copy link
Contributor

Describe the bug

Audio Link will be added to projects without Audio Link during unity 2022 migration

Exactly same issue as #407 with different package

To Reproduce

  1. create avatars 2019 project
  2. migrate the project

Expected behavior

Packages not installed before migration must not be installed after migration (unless it's new dependencies of a packages)

Screenshots

No response

Related Product

VCC (VRChat Creator Companion)

Product Version

2.2.4

OS

Windows 11

Additional context

No response

@anatawa12 anatawa12 added the bug Something isn't working label Feb 26, 2024
@anatawa12
Copy link
Contributor Author

In addition, This warning is shown even if we don't have any (custom) shaders with audiolink
image

@orels1
Copy link
Contributor

orels1 commented Feb 26, 2024

Hmm, odd.
There is logic in place to upgrade pre-1.x AL to 1.x AL if it was already in the project, to avoid it requesting to install UdonSharp for people who were using pre 3.4.x SDKs before the migration.

Was able to reproduce, so I'll look into why a project without audio link might report that it has sub 1.x audiolink installed, thanks for the report 👍

Second issue is with AudioLink itself, it seems to fire every single time no matter if you have any shaders in the project or not. Might be worth creating an issue on the AudioLink repository if you think its a bug.

@orels1
Copy link
Contributor

orels1 commented Feb 27, 2024

This is addressed in VCC 2.2.5 that was just released

@orels1 orels1 closed this as completed Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vpm-core Issues related to the vpm-core
Projects
None yet
Development

No branches or pull requests

2 participants