-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature request] Switch to electron #58
Comments
electron is very buggy and unstable discord and twitch app are examples of this |
VRCX is using cefsharp as webview. cefsharp is c# binding for the chromium embedded framework. electron also using CEF. so there is not much difference. I'm also considering migrating to electron. but this is just a plan. cuz it's to get the benefits of cross-platform, not for performance. and it needs to port some features written in native c# to javascript or nodejs extension (c++). however, there is no guarantee that this will provide better performance. sorry about the performance of VRCX. it looks like a simple web page, but it does a lot of complex things internally (vr overlay, logging, etc). but, there are many things to optimize or improve. I will fix it someday. 😖 |
oomf and next time code bad'nt .-. |
I know this is a rather old thread, but I just wanted to say... knowing node and js performance overall I would think it would be a better thing to stay with cefSharp than switching to node and electron. cefSharp should run cross platform too and if you can get all the other libraries used to run cross platform you can compile with mono / dotNet Core and run the application on linux or even mac (though I don't think VRC runs on macs) Maybe I can get my development environment for linux set up some time and attempt a linux version. |
I don't think CefSharp can work with mono but maybe .NET Core? I'm not sure haven't really looked into it, but cross platform support would be great. |
This error is unrelated, also I have no clue how or why you got this error. |
Both programs use Cef so it seems the installer can't distinguish between these 2 programs, it is a OBS installer bug. |
the installer goes by what applications process handle lock the folder, lots of apps randomly lock the obs folder, ive noticed vrcx, everything, firefox and free download manager do this, even have had it happen with the plastic scm folder getting process locked by unrelated apps. just tried to update plastic now |
i'm not even remotely an expert on this stuff
so if I say some dumb shiet, you know why
Considering that a large part of VRCX is based on a browser, why not change to electron
it's probably a lot faster than the webview used by the os
Considering I often see a kinda high usage in the background (0.7~5%) with 6+ threads
and it's one of the most CPU intensive apps on idle (at least for me with a ryzen 7 3800x)
I'm not saying that a full rewrite/change to Electron is a good idea
but
I think that integrating it for the user interface wouldn't be so bad
Any thoughts?
also I love the app so much
The text was updated successfully, but these errors were encountered: