Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] default tag support for slices #19

Closed
GrigoriyMikhalkin opened this issue Nov 19, 2018 · 1 comment
Closed

[Feature Request] default tag support for slices #19

GrigoriyMikhalkin opened this issue Nov 19, 2018 · 1 comment

Comments

@GrigoriyMikhalkin
Copy link
Contributor

Currently default tag is unsupported on slices. As it explained here:

The default tag is unsupported on slices because slice parsing uses , as the separator, as does the envconfig tags separator.

What I propose is to change default tag to support following format:

default=value1;value2;etc

If this value will be applied to slice, it will be split by ;. If applied to string, value is applied as is. Else, it will panic. I would gladly implement this feature.

@vrischmann
Copy link
Owner

Hi,

I guess that could work yes. I'd be happy to review your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants