Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accidental Global vars #57

Closed
Bobbyjoness opened this issue Nov 27, 2015 · 3 comments
Closed

Accidental Global vars #57

Bobbyjoness opened this issue Nov 27, 2015 · 3 comments

Comments

@Bobbyjoness
Copy link

There seem to a couple accidental global vars in Camera.lua

@vrld
Copy link
Owner

vrld commented Nov 27, 2015

Are you sure?

> before, after = {}, {}
> for k in pairs(_G) do before[#before+1] = k end
> require 'camera'
> for k in pairs(_G) do after[#after+1] = k end
> = #before - #after
0

@Bobbyjoness
Copy link
Author

You just required it wouldn't any globals be initialized through use? But the linear smoother has one I think. I could of sworn I saw more though.

@vrld
Copy link
Owner

vrld commented Nov 27, 2015

Ah, you’re right!

@vrld vrld closed this as completed in 2de9a30 Nov 27, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants