Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meshを正規化するときに、法線を正規化する #1363

Merged
merged 1 commit into from Nov 8, 2021

Conversation

ousttrue
Copy link
Contributor

@ousttrue ousttrue commented Nov 8, 2021

さもないと blendshape が壊れる

#1354

vrm-0.88 original fbx fixed

blender由来の z-up mesh が起因で 行列に回転が入っていることでトリガーするかもしれない。

さもないと blendshape が壊れる
@ousttrue ousttrue requested a review from Santarh November 8, 2021 07:10
@ousttrue ousttrue added bug Something isn't working exporter labels Nov 8, 2021
@ousttrue ousttrue added this to the v0.89 milestone Nov 8, 2021
Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.khronos.org/registry/glTF/specs/2.0/glTF-2.0.html#meshes-overview
glTF の仕様としても normal は normalized されていることを想定している気がします。

Normalized XYZ vertex normals

@Santarh
Copy link
Contributor

Santarh commented Nov 8, 2021

厳密に「normalized されているべき」という記述は見つけられてない

@ousttrue ousttrue merged commit f785bf1 into vrm-c:master Nov 8, 2021
@ousttrue ousttrue deleted the fix/mesh_normalization branch January 24, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working exporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants