VRM は Animation をエクスポートしない #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Santarh
requested changes
Feb 22, 2022
| } | ||
| #endregion | ||
| // 関連する一部の関数が Editor 専用のため、 | ||
| // Editor 時のみ Export する。 |
There was a problem hiding this comment.
以下の点からプリプロセッサを使うのをやめ、 ExportAnimations の実装の先頭で if (!Applications.isPlaying) で判別するべきかなと思います。
using UnityEditorしていないので、プリプロセッサで囲う必要が無いExportAnimationsは override されうるので Editor の関数を使うかどうかは内部実装に依る
This was referenced Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1522
virtual void gltfExporter.ExportAnimations()を切り出した。