glTFTexture.source type to int? #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Santarh
previously approved these changes
Sep 5, 2022
| } | ||
| } | ||
|
|
||
| public static (SubAssetKey, TextureDescriptor) BaseColorTexture(GltfData data, glTFMaterial src) | ||
| public static bool TryBaseColorTexture(GltfData data, glTFMaterial src, out (SubAssetKey, TextureDescriptor) value) |
There was a problem hiding this comment.
自分としては T? が書ける現状、 out キーワードよりも
(SubAssetKey, TextureDescriptor)? BaseColorTexture(GltfData data, glTFMaterial src)
の方がいいのかなとは思うのですがどうでしょう？
There was a problem hiding this comment.
null チェックと tuple 展開を１手でやる方法が無いので。
try かつ tuple やめるやな。
out SubAssetKey key, out TextureDescriptor desc| @@ -58,8 +58,7 @@ public class glTFTexture | |||
| [JsonSchema(Minimum = 0)] | |||
| public int sampler; | |||
|
|
|||
| [JsonSchema(Minimum = 0)] | |||
| public int source; | |||
| public int? source; | |||
| { | ||
| if (string.IsNullOrEmpty(value.Item2.UnityObjectName)) | ||
| { | ||
| throw new ArgumentNullException(); |
There was a problem hiding this comment.
従来なかった null チェックがはさまっていますが、これは？
There was a problem hiding this comment.
もう忘れてしまった。
何らかのエラーが出るのを早期に落とそうとしているぽいが、
忘れたので消そう。
Santarh
approved these changes
Sep 5, 2022
| @@ -35,19 +35,20 @@ public static (SubAssetKey, TextureDescriptor) CreateSrgbFromOnlyImage(GltfData | |||
| return (texDesc.SubAssetKey, texDesc); | |||
| } | |||
|
|
|||
| public static bool TryCreateSrgb(GltfData data, int textureIndex, Vector2 offset, Vector2 scale, out (SubAssetKey, TextureDescriptor) value) | |||
| public static bool TryCreateSrgb(GltfData data, int textureIndex, Vector2 offset, Vector2 scale, out SubAssetKey key, out TextureDescriptor desc) | |||
There was a problem hiding this comment.
たしかに out にするならこっちの方がよさそうですね
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #1417