TransparentなOutlineの描画に対応する #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notargs
commented
May 9, 2023
| renderPassEvent = RenderPassEvent.AfterRenderingOpaques | ||
| }; | ||
| _opaquePass = new MToonOutlineRenderPass(RenderPassEvent.AfterRenderingOpaques, RenderQueueRange.opaque); | ||
| _transparentPass = new MToonOutlineRenderPass(RenderPassEvent.BeforeRenderingTransparents, RenderQueueRange.transparent); |
There was a problem hiding this comment.
Transparent、Opaqueそれぞれでフィルタし、Skyboxの前後で実行する
There was a problem hiding this comment.
There was a problem hiding this comment.
半透明マテリアルにおける輪郭線描画の順序が
Built-in RP: 本体 → 輪郭線
URP: 輪郭線 → 本体
になるという挙動差になったが、これは Built-in RP では難しかっただけで本来は URP 版の挙動が望ましいので大いに OK
Santarh
approved these changes
May 9, 2023
| renderPassEvent = RenderPassEvent.AfterRenderingOpaques | ||
| }; | ||
| _opaquePass = new MToonOutlineRenderPass(RenderPassEvent.AfterRenderingOpaques, RenderQueueRange.opaque); | ||
| _transparentPass = new MToonOutlineRenderPass(RenderPassEvent.BeforeRenderingTransparents, RenderQueueRange.transparent); |
There was a problem hiding this comment.
| renderPassEvent = RenderPassEvent.AfterRenderingOpaques | ||
| }; | ||
| _opaquePass = new MToonOutlineRenderPass(RenderPassEvent.AfterRenderingOpaques, RenderQueueRange.opaque); | ||
| _transparentPass = new MToonOutlineRenderPass(RenderPassEvent.BeforeRenderingTransparents, RenderQueueRange.transparent); |
There was a problem hiding this comment.
半透明マテリアルにおける輪郭線描画の順序が
Built-in RP: 本体 → 輪郭線
URP: 輪郭線 → 本体
になるという挙動差になったが、これは Built-in RP では難しかっただけで本来は URP 版の挙動が望ましいので大いに OK
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransparentなOutlineの描画に対応します
Transparentの場合でも、Skyboxの描画前にOutlineの描画が走ってしまう問題を修正