Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vrmc_materials_mtoon_render_pipelineにURPに関する知識を隔離する #2062

Merged
merged 6 commits into from
May 16, 2023

Conversation

notargs
Copy link
Contributor

@notargs notargs commented May 10, 2023

vrmc_materials_mtoon_render_pipeline.hlsl を切り出し、そこ以外の各種ロジックからURPに関する知識を隔離しました。

このPRでやらないこと

  • AdditionalLightingのロジックの修正
    • これは対応コストの高さが予測されるため、後回しにする

@notargs notargs changed the title [WIP]Refactor mtoon urp vrmc_materials_mtoon_render_pipelineにURPに関する知識を隔離する May 11, 2023
@notargs notargs requested a review from Santarh May 11, 2023 08:59
@ousttrue ousttrue added the URP label May 15, 2023
Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ナイスリファクタリング

@Santarh Santarh merged commit 2d0ed3f into vrm-c:master May 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants