springbone の import で throw しない #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix vrm-c#2023 SpringBone は不完全になるが throw しない。
Santarh
previously approved these changes
Jun 5, 2023
Santarh
reviewed
Jun 5, 2023
| @@ -335,6 +335,17 @@ async Task<MeshWithMaterials> BuildMeshAsync(IAwaitCaller awaitCaller, Func<stri | |||
| #region Imported | |||
| protected GameObject Root; | |||
| public List<Transform> Nodes = new List<Transform>(); | |||
| public bool TryGetNode(int index, out Transform node) | |||
|
Unity 上で構成を変更した場合に、Spring とか HumanoidBone とかが参照しているノードが居なくなることがあって、 |
|
UniGLTF 層の glTF JSON 型定義を、VRM 1.0 と同様の水準にもっていきたいですね～ > |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #2023
index の範囲違反を含む SpringBone を import したときに throw しない。
SpringBone の import は中途半端な状態になるが、VRM 全体としてはロードできるようになる。
export 時の index -1 チェックをひとつ追加。