Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

human bone の index が -1 になりうる? #2074

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

ousttrue
Copy link
Contributor

@ousttrue ousttrue commented Jun 5, 2023

fixed #2072

分からない。いちおう修正。

Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extensions.VRM.humanoid.humanBones に含まれる node の値がなんらか不正っぽい issue。
Animator から取得できる Transform としては存在しているが、なんらか出力対象外の Transform ツリー以下にある等が考えられる?

とりあえずの対策として飛ばしてしまう、というこの修正はそれでよさそう。

それはそれとして、その場合は出力エラーにしてしまってもいいだろう、とは思いつつ… VRM 0.x の実装は現状維持方向でどちらでもという感じ…

@ousttrue ousttrue merged commit f2ed559 into vrm-c:master Jun 5, 2023
1 check passed
@ousttrue ousttrue deleted the check_humanoid_edge_case branch January 24, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UniVRMが不正なVRMを出力出来るべきではない
2 participants