[vrm-animation] VrmAnimationExporter の実装と bvh 変換の実験 #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ousttrue
commented
Jun 19, 2023
| GltfExportSettings settings) | ||
| : base(data, settings) | ||
| { | ||
| settings.InverseAxis = Axes.X; |
There was a problem hiding this comment.
VRM-1.0 仕様に合わせて、x-inverse
ousttrue
commented
Jun 19, 2023
| { | ||
| base.Export(new RuntimeTextureSerializer()); | ||
|
|
||
| addFrames(this); |
There was a problem hiding this comment.
ここで具体的なエクスポートをする。
- 初期化
- each frame
- 書き出し
ousttrue
commented
Jun 19, 2023
| // setup | ||
| // | ||
| var map = new Dictionary<HumanBodyBones, Transform>(); | ||
| var animator = bvh.Root.GetComponent<Animator>(); |
There was a problem hiding this comment.
humanoid を利用するため animator 経由で transform を得る
ousttrue
commented
Jun 19, 2023
| var vrmBone = Vrm10HumanoidBoneSpecification.ConvertFromUnityBone(kv.Key); | ||
| var parent = GetParentBone(map, vrmBone) ?? bvh.Root.transform; | ||
| vrma.AddRotationBoneAndParent(kv.Key, kv.Value, parent); | ||
| } |
There was a problem hiding this comment.
ここまでで T-Pose を登録している
ousttrue
commented
Jun 19, 2023
| state.time = (float)time.TotalSeconds; | ||
| animation.Sample(); | ||
| vrma.AddFrame(time); | ||
| } |
Santarh
previously approved these changes
Jul 3, 2023
|
使える bvh の条件と、humanbone 割り当て関連の注意書きを追加しました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API としてはもうちょっと分かりやすいものにできそうだけど、とりあえず動くものを。
の３ステップに組み替えて Exporter を隠蔽した方が良いかもしれない。