Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample コピーが同一かどうかを確認する #2103

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

ousttrue
Copy link
Contributor

@ousttrue ousttrue commented Jul 5, 2023

UnityPackage 作成時に確認。

fixed #2016

@ousttrue ousttrue requested a review from Santarh July 5, 2023 05:09
@ousttrue ousttrue added this to the v0.113 milestone Jul 5, 2023
@Santarh
Copy link
Contributor

Santarh commented Jul 6, 2023

Jenkins

@@ -187,6 +187,11 @@ public PackageInfo(string name)

public static void CreateUnityPackages(string outputDir)
{
if (!VRMSampleCopy.Validate())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

たしかにこのタイミングで良いか。
「落ちてもいいユニットテスト」として定義できるといいかもしれないなと思ったが

@ousttrue ousttrue merged commit 904ce47 into vrm-c:master Jul 7, 2023
1 check passed
@ousttrue ousttrue deleted the fix/validate_no_sample_copy branch January 24, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Samples~ へのコピー忘れる件
2 participants