Auto detect render pipelines #2114
Conversation
These allow for the creation of materialdescriptorgenerators that use the current render pipeline
… used elsewhere in my local version of UniVRM I have the change I made, and will leave other changes to your discretion
|
Can one of the admins verify this patch? |
|
Jenkins |
|
|
||
| if (currentPipeline == null) | ||
| { | ||
| return RenderPipelineTypes.Unknown; |
There was a problem hiding this comment.
It seems to be RenderPipelineTypes.BuiltinRenderPipeline when currentPipelin is null.
There was a problem hiding this comment.
I will try make the changes. Just need some more details.
Do you mean that the null check is not working?
Can I see the output of the unit test in question?
There was a problem hiding this comment.
I understand that currentPipeline == null means current render pipeline is Built-in RenderPipeline in Unity.
But this implementation has different behaviour.
The loader can't decide RenderPipelineTypes correctly when Project's RenderPipeline is Built-in RenderPipeline.
Suggested change is below.
| return RenderPipelineTypes.Unknown; | |
| return RenderPipelineTypes.BuiltinRenderPipeline; |
How to run unit tests
Select Window -> General -> Test Runner then Test Runner Windows is opened.
In Test Runner Window, select Run All button then tests are running.
You can find failed tests in the list.
|
Jenkins |
This PR adds code to automatically detect the render pipeline and adds utility functions that returns the correct
IMaterialDescriptorGeneratorbased on the current pipeline.It also implements a use case in the Vrm10Importer that means that in a URP project at runtime a VRM10 is loaded in using the correct materials.