EditorImport時、ユーザーが任意のMaterialDescriptorGeneratorを差し込むための拡張の窓を追加 #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Santarh
requested changes
Aug 8, 2023
| } | ||
|
|
||
| return renderPipeline switch |
There was a problem hiding this comment.
ProjectSettings による override がなければデフォルトの実装を返す
| namespace VRM10.Settings | ||
| { | ||
| [FilePath("ProjectSettings/Vrm10ProjectEditorSettings.asset", FilePathAttribute.Location.ProjectFolder)] | ||
| internal class Vrm10ProjectEditorSettings : ScriptableSingleton<Vrm10ProjectEditorSettings> |
There was a problem hiding this comment.
ScriptableSingleton<T> 、そういうのも生えてたんだなあ
| @@ -16,17 +17,18 @@ public static class VrmScriptedImporterImpl | |||
| { | |||
| static IMaterialDescriptorGenerator GetMaterialDescriptorGenerator(RenderPipelineTypes renderPipeline) | |||
| { | |||
| switch (renderPipeline) | |||
| var settings = Vrm10ProjectEditorSettings.instance; | |||
There was a problem hiding this comment.
ScriptableSingleton<T>.instance は初回アクセス時にインスタンスを生成するのでおそらく null にはならない
https://docs.unity3d.com/ja/2021.2/ScriptReference/ScriptableSingleton_1-instance.html
| [SettingsProvider] | ||
| public static SettingsProvider CreateProvider() => new Vrm10ProjectSettingsProvider(); | ||
|
|
||
| private string AssetPath = "Assets/Vrm10ProjectEditorSettings.asset"; |
There was a problem hiding this comment.
使われて無さそう？なんらか実装の変更で不要になったもの？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
プロジェクト固有のShaderを用いてEditorImportを行いたいユースケースに対応するために
任意のMaterialDescriptorGeneratorを差し込むための拡張の仕組みを追加しました
MaterialDescriptorGeneratorFactoryabstract classを継承したScriptableObjectを作り、ProjectSettingsからアタッチすることで、任意のMaterialDescriptorGeneratorを利用することができます