New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vrm10RuntimeExpression.SetWeightNonAlloc method #2128

Merged

Santarh merged 1 commit into vrm-c:master from notargs:set_weights_non_alloc

Aug 15, 2023

Contributor

notargs commented Aug 15, 2023

Dictionaryを受け取るバージョンであるSetWeightsNonAllocを作りました
DictionaryをIEnumerableとして列挙する際にGC Allocが発生しますが、このAPIを使うことでそれを回避することが出来ます


          Add Vrm10RuntimeExpression.SetWeightNonAlloc method

4621d51

notargs requested a review from Santarh

August 15, 2023 03:18

Santarh approved these changes

View reviewed changes

Contributor

Santarh left a comment

ありがとうございます！

毎フレーム呼び出すことが期待される関数で GC はなるべく発生させたくない
SetWeights のオーバーロードとして定義すると Ambiguous になるので避けたい
~~NonAlloc という命名は Unity の API にも存在する

ということで…… LGTM！

Santarh merged commit d24cdbd into vrm-c:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment