Add ReplaceResource Method to RuntimeGltfInstance
#2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enables resource replacement for Texture, Material, AnimationClip, and Mesh - Provides error handling for null or mismatched types - Destroys the old resource after replacement
|
Can one of the admins verify this patch? |
|
Jenkins |
|
Thanks for the pull request. |
|
Thanks all 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
ReplaceResourcemethod to theRuntimeGltfInstanceclass. This enables resource replacement of Textures, Materials, AnimationClips, and Meshes. The old resource is destroyed after replacement.In our project we integrated UniVRM for handling VRM imports. In a recent optimization effort we encountered the need to downscale the textures of imported VRMs during runtime. However we ran into issues regarding UniGLTF as the
RuntimeGltfInstanceclass stores textures and other resources in a readonly list with no way to modify the contents from an external class. TheReplaceResourcemethod is our solution to this limitation. By introducing this method, we can effectively modify and replace resources in the readonly list, ensuring efficient memory in our project.