[vrma] retarget phase を Vrm10Runtime.Process の先頭に移動 #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Santarh
requested changes
Aug 16, 2023
| /// * Spring | ||
| /// * LookAt | ||
| /// * Expression | ||
| /// | ||
| /// </summary> | ||
| public void Process() | ||
| { | ||
| // 0. Update From VrmAnimation |
| @@ -1,6 +1,6 @@ | |||
| using UnityEngine; | |||
|
|
|||
| namespace UniVRM10.VRM10Viewer | |||
| namespace UniVRM10 | |||
| @@ -1,6 +1,6 @@ | |||
| using UnityEngine; | |||
|
|
|||
| namespace UniVRM10.VRM10Viewer | |||
| namespace UniVRM10 | |||
| { | |||
| public static class VRM10Retarget | |||
There was a problem hiding this comment.
周りのクラスの命名が Vrm10 なので Vrm10Retarget にしましょう
|
|
||
| namespace UniVRM10 | ||
| { | ||
| public interface IVrmAnimation : IDisposable |
There was a problem hiding this comment.
UniVRM としては VRM 1.0 の実装は Vrm10 Prefix をつけるということに経過的になっているし
IVrm10Animation の方が良い気はします
| @@ -5,11 +5,30 @@ | |||
|
|
|||
| namespace UniVRM10 | |||
| { | |||
| public class VrmAnimationInstance : MonoBehaviour | |||
| public class VrmAnimationInstance : MonoBehaviour, IVrmAnimation | |||
There was a problem hiding this comment.
同様に Vrm10AnimationInstance かなあ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleVrma サンプルを追加