LookAt の整理 #2138
Merged
LookAt の整理 #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ousttrue
commented
Aug 18, 2023
| @@ -51,46 +51,46 @@ public Vector3 ExternalForce | |||
| } | |||
| } | |||
|
|
|||
| public Vrm10Runtime(Vrm10Instance target, bool useControlRig) | |||
| public Vrm10Runtime(Vrm10Instance instance, bool useControlRig) | |||
There was a problem hiding this comment.
target が LookAt target と紛らわしいような気がしたので、名前変更。
ousttrue
commented
Aug 18, 2023
| @@ -229,10 +214,37 @@ public void Process() | |||
| } | |||
|
|
|||
| // 4. Gaze control | |||
| LookAt.Process(m_target.LookAtTargetType, m_target.LookAtTarget); | |||
| LookAtInput lookAtInput = default; | |||
There was a problem hiding this comment.
VrmAnimation により LookAt の入力が、
VrmAnimation, Transform 追跡、SetYawPitch の三択 になりました。
There was a problem hiding this comment.
さらに変更。
Transform 追跡 は AutoBlink 的な感じ。
ousttrue
commented
Aug 18, 2023
| @@ -8,5 +9,6 @@ public interface IVrm10Animation : IDisposable | |||
| (INormalizedPoseProvider, ITPoseProvider) ControlRig { get; } | |||
| IReadOnlyDictionary<ExpressionKey, Func<float>> ExpressionMap { get; } | |||
| public void ShowBoxMan(bool enable); | |||
| LookAtInput? LookAt { get; } | |||
There was a problem hiding this comment.
VrmAnimation から LookAt を供給する。まだ入れ物だけ
ousttrue
commented
Aug 18, 2023
| /// 入力値。適宜更新可。 | ||
| /// </summary> | ||
| public LookAtInput LookAtInput { get; private set; } | ||
|
|
There was a problem hiding this comment.
LookAtInput を入力、 EyeDirection を出力とした。
Santarh
previously approved these changes
Aug 18, 2023
| } | ||
|
|
||
| /// <summary> | ||
| /// Yaw/Pitch 値を直接設定します。 | ||
| /// LookAtTargetTypes が SpecifiedTransform の場合、ここで設定しても値は上書きされます。 | ||
| /// Vrm10Instance.LookAtTargetTypes が SpecifiedTransform の場合、ここで設定しても値は上書きされます。 | ||
| /// </summary> | ||
| /// <param name="yaw">Headボーンのforwardに対するyaw角(度)</param> | ||
| /// <param name="pitch">Headボーンのforwardに対するpitch角(度)</param> | ||
| public void SetYawPitchManually(float yaw, float pitch) |
Comment on lines
+16
to
24
| /// <summary> | ||
| /// 入力値。適宜更新可。 | ||
| /// </summary> | ||
| public LookAtInput LookAtInput { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// 出力値。Process() のみが更新する | ||
| /// </summary> | ||
| public LookAtEyeDirection EyeDirection { get; private set; } |
There was a problem hiding this comment.
Vrm10RuntimeLookAt は
LookAtInputという「LookAt する対象」をユーザ入力として- それを
Process()で処理し LookAtEyeDirectionという「実際に Bone や BlendShape といったILookAtEyeDirectionApplicableが適用すべき LookAt の状態」を出力する
システムになる。
左目と右目の独立はまたの機会に・・・
Santarh
reviewed
Aug 18, 2023
| /// NOTE: 何故か使われていない | ||
| /// Pitch of RightEye | ||
| /// </summary> | ||
| public float RightPitch { get; } |
There was a problem hiding this comment.
今の段階では左右の目の YawPitch を区別する必要はない。
将来的にも規格レベルで解決するべきハードルが高いので、またいずれ……
参考：vrm-c/vrm-specification#177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LookAtInput を導入して、LookAt を整理。