Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a incorrect eye direction control in VRM-1.0. #2163

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Fix a incorrect eye direction control in VRM-1.0. #2163

merged 3 commits into from
Oct 12, 2023

Conversation

Santarh
Copy link
Contributor

@Santarh Santarh commented Oct 11, 2023

Fix #2159

次の問題を修正した

  • VRM 1.0 の、ボーンを利用した目線制御において
    • 実装が間違っており、ボーンの回転が identity でないときにおかしくなっていた
    • 左目の Outer/Inner 制限角度が反転していた

@Santarh Santarh requested a review from ousttrue October 11, 2023 09:44
ousttrue
ousttrue approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@ousttrue ousttrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ousttrue ousttrue added this to the v0.115 milestone Oct 12, 2023
@ousttrue ousttrue added 1.0 LookAt/FirstPerson create headless model for VR labels Oct 12, 2023
@ousttrue ousttrue merged commit 18285bf into vrm-c:master Oct 12, 2023
1 check passed
@Santarh Santarh deleted the lookAtBugFix branch October 12, 2023 04:23
@saturday06 saturday06 mentioned this pull request Oct 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ousttrue ousttrue ousttrue approved these changes

Assignees
No one assigned
Labels
1.0 LookAt/FirstPerson create headless model for VR
Projects
None yet
Milestone
v0.115 PR merge
2 participants
@Santarh @ousttrue