TEXCOORD_1 は export しない #2172
Merged
TEXCOORD_1 は export しない #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ousttrue
changed the title
Santarh
approved these changes
Oct 23, 2023
| /// <summary> | ||
| /// Export TEXCOORD_1 | ||
| /// </summary> | ||
| public bool ExportUvSecondary; |
There was a problem hiding this comment.
将来的に uv 3 番目、4 番目…となる可能性はあると思うが、じゃあ bool[] とかにするかというとそれも違うなあとは思うので、そうなったら愚直に追加でいいか。
| /// </summary> | ||
| public bool KeepVertexColor; | ||
| public bool ExportVertexColor; |
| @@ -43,12 +43,16 @@ public static class MeshExporter_SharedVertexBuffer | |||
| } | |||
|
|
|||
| var uvAccessorIndex0 = data.ExtendBufferAndGetAccessorIndex(mesh.uv.Select(y => y.ReverseUV()).ToArray(), glBufferTarget.ARRAY_BUFFER); | |||
| var uvAccessorIndex1 = data.ExtendBufferAndGetAccessorIndex(mesh.uv2.Select(y => y.ReverseUV()).ToArray(), glBufferTarget.ARRAY_BUFFER); | |||
There was a problem hiding this comment.
おそらく、#1798 を契機に mesh.uv2 が null にならなくなったと思われます。
で mesh エクスポートの経路が glbとvrm0(shared / divided) + vrm1 で３種類あって、
今回修正した glb/vrm0 shared だけ uv2 が漏れ出るようになってしまった。
他の２本は、あとで作ったときに最初から uv2 をオミットしているぽい。
vertexbuffer(shared) が歴史的経緯により一番古い。
| var uvAccessorIndex1 = -1; | ||
| if (settings.ExportUvSecondary) | ||
| { | ||
| uvAccessorIndex1 = data.ExtendBufferAndGetAccessorIndex(mesh.uv2.Select(y => y.ReverseUV()).ToArray(), glBufferTarget.ARRAY_BUFFER); |
There was a problem hiding this comment.
具体的な出力実装は変えず、出力するかどうかを選択式にした
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #2167
現状、Unity 上で２番目以降の UV を正しく反映する実装が無いのでエクスポートしない。
正しく反映 するには glTF と互換性のある shader にする必要があるのだが、
Unity の Standard と glTF の仕様が違うので対応予定無し。
https://github.com/KhronosGroup/glTF/blob/main/specification/2.0/schema/textureInfo.schema.json#L13