[Mesh統合] glb/vrm-0/vrm-1 の Mesh統合 Utility を整理 #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prefab 時は instance 化する。統合グループをの内容をインスタンス後のもので置き換える - 未使用削除
automatically force when createAvatar
ousttrue
commented
Dec 6, 2023
| using UnityEditor; | ||
| using UnityEditorInternal; | ||
| using UnityEngine; | ||
|
|
||
| namespace UniVRM10 | ||
| namespace UniGLTF.MeshUtility |
ousttrue
commented
Dec 6, 2023
| // Meshの焼きこみ | ||
| var newMesh = BoneNormalizer.NormalizeHierarchyFreezeMesh(go, true); | ||
| // 焼いたMeshで置き換える | ||
| BoneNormalizer.Replace(go, newMesh, true, true); |
There was a problem hiding this comment.
Mesh を焼くのと、焼いた Mesh を Renderer に挿すを分けた。
挿すときに Transform.rotation / scale のクリアをする。
ousttrue
commented
Dec 6, 2023
| /// <summary> | ||
| /// Meshを統合し、統合後のMeshのBlendShapeの変化をVRMのBlendShapeClipに反映する | ||
| /// </summary> | ||
| public class VrmBlendShapeUpdater |
There was a problem hiding this comment.
Mesh統合でずれるBlendShape参照を追随させる
ousttrue
commented
Dec 6, 2023
|
|
||
| namespace UniGLTF.MeshUtility | ||
| { | ||
| public class MeshAttachInfo |
There was a problem hiding this comment.
Mesh を焼いたときに Renderer を置き換えるのをやめたので、
置き換え情報を蓄える。
Santarh
previously approved these changes
Dec 6, 2023
Comment on lines
37
to
45
| public void WriteAndReload(string assetPath) | ||
| { | ||
| AssetDatabase.CreateAsset(IntegratedRenderer.sharedMesh, assetPath); | ||
| var unityPath = UnityPath.FromUnityPath(assetPath); | ||
| unityPath.ImportAsset(); | ||
| var mesh = unityPath.LoadAsset<Mesh>(); | ||
| // replace reloaded | ||
| IntegratedRenderer.sharedMesh = mesh; | ||
| } |
There was a problem hiding this comment.
これ、処理は public な状態を読み書きしているので、関数自体は Editor の asmdef に押しやれそうな気はします。
（プリプロセッサなくしたい）
| } | ||
| else | ||
| { | ||
| #if VRM_DEVELOP |
There was a problem hiding this comment.
プリプロセッサ外したとしてもコンパイルエラーになるコードではないので
if (Symbols.VRM_DEVELOP)
としてほしいかも
ousttrue
commented
Dec 6, 2023
| { | ||
| var childAssetPath = $"{assetFolder}/{result.Integrated.IntegratedRenderer.gameObject.name}{ASSET_SUFFIX}"; | ||
| Debug.LogFormat("CreateAsset: {0}", childAssetPath); | ||
| AssetDatabase.CreateAsset(result.Integrated.IntegratedRenderer.sharedMesh, childAssetPath); |
There was a problem hiding this comment.
AssetDatabase.CreateAsset を後続の result.Integrated.Reload から移動
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
共通機能を glb 版の runtime 動作に実装した。
重複していた部分などを整理。
freeze(bake) => 統合 => 分割
統合対象を
ブラックリストで除外するのを、
ホワイトリストで列挙する様に変えた。