[MeshUtility] 非原点 SkinnedMeshRenderer まわりの修正 #2188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Santarh
approved these changes
Dec 11, 2023
| @@ -9,6 +9,11 @@ namespace UniVRM10 | |||
| { | |||
| public class Vrm10MeshUtility : UniGLTF.MeshUtility.GltfMeshUtility | |||
| { | |||
| public Vrm10MeshUtility() | |||
| { | |||
| FreezeRotation = true; | |||
There was a problem hiding this comment.
この場合の Freeze ってどちらの操作を指すのでしょう？
自分の印象としては Freeze は Bake の同義語で「回転成分を正規化する」ように思えました。
実際は逆？
There was a problem hiding this comment.
Freeze = Bake であってます。
現状、FreezeRotation = false の実装が無いので、とりえあず。
FreezeRotation = false の場合、bake 後に回転を復旧する的な作業が必用で重い。
次以降のバージョンで実装します・・・
| rotation | scale | |
|---|---|---|
| 〇 | 〇 | vrm-0.xの正規化。できる |
| 〇 | TODO | |
| 〇 | 実装しない | |
| 何もしない |
bool ２つは変えようと思った。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2119 (非原点 SkinnedMeshRenderer Weightあり・なし) の修正と、発見されたバグの修正