Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build error を修正 #2194

Merged
merged 4 commits into from
Dec 12, 2023
Merged

build error を修正 #2194

merged 4 commits into from
Dec 12, 2023

Conversation

ousttrue
Copy link
Contributor

  • remove symbol ENABLE_UNITY_COLLECTIONS_CHECKS
  • WriteAndReload
  • sample のファイルダイアログの応急処置

@ousttrue ousttrue added this to the v0.116 MeshIntegration milestone Dec 12, 2023
Santarh
Santarh approved these changes Dec 12, 2023
View reviewed changes
Assets/VRM10/Samples~/SimpleVrma/SimpleVrma.cs
@@ -15,6 +17,7 @@ public class SimpleVrma : MonoBehaviour

void OnGUI()
{
#if UNITY_EDITOR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これは仕方ない #if UNITY_EDITOR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

まあ CustomEditor 用のクラスを定義する手はあるか

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

monobehaviour だけ例外的に UNITY_EDITOR する場合

@ousttrue ousttrue merged commit dd28473 into vrm-c:master Dec 12, 2023
1 check failed
@ousttrue ousttrue deleted the fix/build_errors branch January 24, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Santarh Santarh Santarh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.116 MeshIntegration
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ousttrue @Santarh