Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[提案] RuntimeGltfInstance.OnDestroy時のDebug.Logを削除する #2223

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

tsgcpp
Copy link
Contributor

@tsgcpp tsgcpp commented Jan 11, 2024

概要

RuntimeGltfInstance.OnDestroy時のDebug.Logの削除を提案させていただきます。

ロードしたVRMのインスタンスが破棄されたときに発生するログのようですが、情報が UnityResourceDestroyer.OnDestroy の文字列とスタックトレースのみで用途があまりなさそうと思ったため、スタックトレース生成を含めたログ出力を回避するために削除を提案させていただきます。

@vrm-github-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@ousttrue ousttrue added this to the v0.118 milestone Jan 16, 2024
Copy link
Contributor

@ousttrue ousttrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@ousttrue ousttrue merged commit eb4319c into vrm-c:master Jan 16, 2024
@tsgcpp tsgcpp deleted the feature/remove_log_in_ondestroy branch January 16, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants