[VRM10] FirstPerson の修正 #2252
Merged
[VRM10] FirstPerson の修正 #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ousttrue
added
LookAt/FirstPerson
Santarh
approved these changes
Feb 26, 2024
Comment on lines
+89
to
+94
| var instance = await Vrm10.LoadPathAsync(path, awaitCaller: awaitCaller, showMeshes: false); | ||
|
|
||
| // VR用 FirstPerson 設定 | ||
| await instance.Vrm.FirstPerson.SetupAsync(instance.gameObject, awaitCaller); | ||
|
|
||
| instance.GetComponent<RuntimeGltfInstance>().ShowMeshes(); |
There was a problem hiding this comment.
FirstPerson の SetupAsync をどう呼び出さないといけないか？の知識は
Vrm10.Load~~Async に bool generateFirstPersonModel = false を追加して
Vrm10.Load~~Async の実装の中に入れてしまった方がいいかもしれませんね。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #2209
#2209 の修正が主でしたが、関連して問題がある部分も修正しました。