Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix baseColorFactor color space. #339

Merged
merged 1 commit into from Dec 12, 2019
Merged

fix baseColorFactor color space. #339

merged 1 commit into from Dec 12, 2019

Conversation

hiroj
Copy link
Contributor

@hiroj hiroj commented Dec 12, 2019

Convert baseColorFactor to linearColor when exporting
Convert baseColorFactor to gammaColor when importing

issue

#301

@hiroj hiroj requested a review from ousttrue December 12, 2019 06:44
@hiroj
Copy link
Contributor Author

hiroj commented Dec 12, 2019 •
edited

Unity
ColorValue: 0.0, 0.25, 0.5, 0.75, 1.0
image

UniVRM Export glb, Three.js renderer
GltfColorValue: 0, 0.0508760773, 0.214041144, 0.5225216, 1.0
image

@ousttrue ousttrue merged commit 9de04a3 into vrm-c:master Dec 12, 2019
@hiroj hiroj mentioned this pull request Dec 13, 2019
Closed
@hiroj hiroj mentioned this pull request Feb 6, 2020
Closed
@Santarh Santarh mentioned this pull request Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ousttrue ousttrue ousttrue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hiroj @ousttrue