Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix runtime texture import #786

Merged
merged 1 commit into from Mar 16, 2021
Merged

Conversation

ousttrue
Copy link
Contributor

@ousttrue ousttrue commented Mar 16, 2021

runtime import の修正

                var cacheName = param.ConvertedName;
                if (param.TextureType == GetTextureParam.NORMAL_PROP)
                {
                    cacheName = param.GltflName; // これでキーが変わるときがありえる
                }

                if (m_externalMap.TryGetValue(cacheName, out external))
                {
                    if (!m_textureCache.ContainsKey(cacheName)) // ここで重複確認する
                    {
                        m_textureCache.Add(cacheName, new TextureLoadInfo(external, used, true));
                    }
                    return external;
                }
  • 発生条件: 複数のマテリアルで同じ法線マップを参照している
    • VRoid モデルで起こります

@ousttrue ousttrue changed the title [WIP] fix runtime texture import fix runtime texture import Mar 16, 2021
@Roseweave
Copy link

IS it just source code atm? When will there be a compiled package release?

@ousttrue
Copy link
Contributor Author

v0.68.1

@ousttrue ousttrue deleted the fix/texture_import branch April 2, 2021 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants